API Rename validator classes #129
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/5/valid
branch
from
2cea9e6 to
957e6ad
Compare
8 tasks
emteknetnz
force-pushed
the
pulls/5/valid
branch
from
957e6ad to
31fb634
Compare
GuySartorelli
approved these changes
Dec 9, 2024
|
CI failure shows
The userforms PR did update that reference, so I'm not sure why this is trying to pull in an older version of userforms? Can you please investigate? It seems like a legitimate problem, but I guess could just be CI composer cache or something. |
emteknetnz
force-pushed
the
pulls/5/valid
branch
from
31fb634 to
88efba8
Compare
emteknetnz
force-pushed
the
pulls/5/valid
branch
from
88efba8 to
ee005cc
Compare
|
I've updated the require-dev dep of userforms from ^7 to 7.x-dev, because it is currently just installing 7.0.0-alpha1. Alternative would be to manually release 7.0.0-alpha2. |
GuySartorelli
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#10908