ENH Use SearchableMultiDropdownField #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/5/selectorfield
branch
from
74ba657 to
6e3050c
Compare
Closed
8 tasks
GuySartorelli
requested changes
Dec 4, 2023
emteknetnz
force-pushed
the
pulls/5/selectorfield
branch
from
6e3050c to
4d78299
Compare
|
Have removed $membersMap variable |
GuySartorelli
requested changes
Dec 11, 2023
emteknetnz
force-pushed
the
pulls/5/selectorfield
branch
from
4d78299 to
32f8e3f
Compare
|
Have updated composer.json |
GuySartorelli
approved these changes
Dec 13, 2023
|
This is failing CI |
emteknetnz
force-pushed
the
pulls/5/selectorfield
branch
from
32f8e3f to
24b7aa7
Compare
|
Have updated behat test, though will require this new PR to be merged first - silverstripe/silverstripe-admin#1635 |
GuySartorelli
requested changes
Dec 17, 2023
emteknetnz
force-pushed
the
pulls/5/selectorfield
branch
from
24b7aa7 to
e26d90b
Compare
emteknetnz
force-pushed
the
pulls/5/selectorfield
branch
from
e26d90b to
37e8a4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-admin#1618
CI requires silverstripe/silverstripe-framework#11057 to be merged first
Also requires silverstripe/silverstripe-admin#1635 to be merged