Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Add "only these users" option to siteconfig access settings #146

Merged
merged 2 commits into from
Oct 24, 2023
Merged

ENH Add "only these users" option to siteconfig access settings #146

merged 2 commits into from
Oct 24, 2023

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli mentioned this pull request Oct 19, 2023
Closed
sabina-talipova
sabina-talipova suggested changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@sabina-talipova sabina-talipova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add the similar behaviour for "Only these groups (choose from list)" as we had before. We currently have this only for "Only these users (choose from list)".

code/SiteConfig.php Show resolved Hide resolved
code/SiteConfig.php Show resolved Hide resolved
@GuySartorelli
Copy link
Member Author

Is it possible to add the similar behaviour for "Only these groups (choose from list)" as we had before. We currently have this only for "Only these users (choose from list)".

As discussed offline, that was treated as a separate issue and fixed in silverstripe/silverstripe-admin#1610
The behat tests in this PR validate that it's working as expected. If you make sure you have the latest admin changes you should see it working as expected.

sabina-talipova
sabina-talipova approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@sabina-talipova sabina-talipova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me .

@sabina-talipova sabina-talipova merged commit 0176111 into silverstripe:5 Oct 24, 2023
11 checks passed
@sabina-talipova sabina-talipova deleted the pulls/5/onlytheseusers branch October 24, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabina-talipova sabina-talipova sabina-talipova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @sabina-talipova