Merge pull request #227 from creative-commoners/pulls/3/php84

API Explicity mark nullable parameters for PHP 8.4
silverstripe · Dec 2, 2024 · 437f775 · 437f775
2 parents 30fdc58 + a1ebe0a
commit 437f775
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/Security/LogInAuthenticationHandler.php b/src/Security/LogInAuthenticationHandler.php
@@ -75,7 +75,7 @@ public function authenticateRequest(HTTPRequest $request)
      * @param HTTPRequest|null $request
      * @throws InvalidArgumentException
      */
-    public function logIn(Member $member, $persistent = false, HTTPRequest $request = null)
+    public function logIn(Member $member, $persistent = false, ?HTTPRequest $request = null)
     {
         // Fall back to retrieving request from current Controller if available
         if ($request === null) {
@@ -108,7 +108,7 @@ public function logIn(Member $member, $persistent = false, HTTPRequest $request
     /**
      * @param HTTPRequest $request|null
      */
-    public function logOut(HTTPRequest $request = null)
+    public function logOut(?HTTPRequest $request = null)
     {
         // noop
     }

diff --git a/src/Security/LogOutAuthenticationHandler.php b/src/Security/LogOutAuthenticationHandler.php
@@ -32,7 +32,7 @@ public function authenticateRequest(HTTPRequest $request)
      * @param bool $persistent
      * @param HTTPRequest $request|null
      */
-    public function logIn(Member $member, $persistent = false, HTTPRequest $request = null)
+    public function logIn(Member $member, $persistent = false, ?HTTPRequest $request = null)
     {
         // noop
     }
@@ -41,7 +41,7 @@ public function logIn(Member $member, $persistent = false, HTTPRequest $request
      * @param HTTPRequest $request|null
      * @throws InvalidArgumentException
      */
-    public function logOut(HTTPRequest $request = null)
+    public function logOut(?HTTPRequest $request = null)
     {
         // Fall back to retrieving request from current Controller if available
         if ($request === null) {