Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Remove TODO comments #70

Merged
merged 1 commit into from
Oct 24, 2023
Merged

MNT Remove TODO comments #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/Forms/GridFieldExportReportButton.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ public function generateExportFileData($gridField)
// The is the only variation from the parent, using getList() instead of getManipulatedList()
$items = $gridField->getList();

// @todo should GridFieldComponents change behaviour based on whether others are available in the config?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open ticket: - #69

foreach ($gridField->getConfig()->getComponents() as $component) {
if ($component instanceof GridFieldFilterHeader || $component instanceof GridFieldSortableHeader) {
$items = $component->getManipulatedData($gridField, $items);
Expand Down
1 change: 0 additions & 1 deletion tests/php/UserSecurityReportTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ class UserSecurityReportTest extends SapphireTest
* Utility method for all tests to use.
*
* @return ArrayList
* @todo pre-fill the report with fixture-defined users
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open ticket: - #68

*/
protected function setUp(): void
{
Expand Down