FIX RegistryAdmin add missing return to import #114
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When importing a CSV file into a registry it will complete the import but fails to return (redirect) back to the registry popup dialog with a "good" (successful) message. The user's gets a broken screen (css not loading).
Debugging error logs
[Emergency] Uncaught TypeError: SilverStripe\Registry\RegistryAdmin::import(): Return value must be of type SilverStripe\Control\HTTPResponse, none returned
There is a missing RETURN in file RegistryAdmin > import function > line 126.
silverstripe-registry/src/RegistryAdmin.php
Line 126 in 92c1a52
I've added the return and tested that it works.
Manual testing steps
Issues
#113
Pull request checklist