Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Remove mention of webauthn module #577

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Nov 25, 2024

@andrewandante
Copy link

Hi team, friendly reminder that these are open-source modules and linking to a private repo with no other details in the Pull Request is really unhelpful for evaluation. If you could summarise or otherwise extract the contents of that issue, that'd be fantastic, thanks 👍

@emteknetnz
Copy link
Member Author

emteknetnz commented Nov 25, 2024

Good point - have created a new public issue that contained the relevant content from the private issue silverstripe/.github#342 and will use that as the parent issue going forward

@emteknetnz emteknetnz marked this pull request as ready for review November 26, 2024 04:32
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If webauthn becomes CMS 6 compatible in the future via a community maintainer I'd be happy to bring the mention of it back - but for now this seems sensible.

@GuySartorelli GuySartorelli merged commit 6c7dfdc into silverstripe:6 Nov 26, 2024
13 checks passed
@GuySartorelli GuySartorelli deleted the pulls/6/remove-support branch November 26, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants