Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Linting #533

Merged
Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Apr 8, 2024

Issue #531

Also adds in docs from totp + webauthn modules

@emteknetnz emteknetnz force-pushed the pulls/5.2/doclint branch 6 times, most recently from 3e6e71d to 8c7a606 Compare April 8, 2024 07:53
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

totp and webauthn docs should stay where they are. You can add them as children of the mfa docs by setting the name to something like docs--5--optional_features/mfa/totp or as children of the "authenticators" directory by setting it to something like docs--5--optional_features/mfa/authenticators/totp

Please also add title medadata to all pages.
e.g

---
title: Some Page Name
summary: A brief summary of what the page content is
icon: link
---

The icon and summary are optional.

README.md Outdated Show resolved Hide resolved
docs/en/07_other-authenticators.md Outdated Show resolved Hide resolved
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit ebe4123 into silverstripe:5.2 Apr 9, 2024
13 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5.2/doclint branch April 9, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants