Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Rename validator classes #355

Merged
merged 1 commit into from
Dec 10, 2024
Merged

API Rename validator classes #355

merged 1 commit into from
Dec 10, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz changed the title API Renameator classes valid API Rename validator classes Dec 2, 2024
@emteknetnz emteknetnz mentioned this pull request Dec 2, 2024
Closed
8 tasks
@emteknetnz emteknetnz changed the base branch from 5 to 5.0 December 4, 2024 00:43
@emteknetnz emteknetnz marked this pull request as ready for review December 9, 2024 05:05
GuySartorelli
GuySartorelli approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM will merge when all PRs are good to go

@GuySartorelli
Copy link
Member

CI is failing with

PHP Fatal error:  Could not check compatibility between DNADesign\Elemental\Tests\Blocks\TestElementContent::getCMSCompositeValidator(): SilverStripe\Forms\CompositeValidator and SilverStripe\ORM\DataObject::getCMSCompositeValidator(): SilverStripe\Forms\Validation\CompositeValidator, because class SilverStripe\Forms\CompositeValidator is not available in /home/runner/work/silverstripe-linkfield/silverstripe-linkfield/vendor/dnadesign/silverstripe-elemental/tests/Blocks/TestElementContent.php on line 56

Can you please investigate whether that's a legitimate issue or if CI is just having caching trouble or similar?

@emteknetnz emteknetnz force-pushed the pulls/5/valid branch 3 times, most recently from 44403e4 to 528cdec Compare December 10, 2024 03:23
@emteknetnz
Copy link
Member Author

emteknetnz commented Dec 10, 2024 •
edited
Loading

I've updated the require-dev dep of elemental from ^6 to 6.x-dev, because it is currently just installing 6.0.0-alpha1. Alternative would be to manually release 6.0.0-alpha2.

However I need to merge up elemental since the latest code went to 6.0.x-dev though cannot do that via github actions until this PR is merged silverstripe/gha-merge-up#47

@emteknetnz emteknetnz mentioned this pull request Dec 10, 2024
Closed
@GuySartorelli GuySartorelli merged commit b16113e into silverstripe:5.0 Dec 10, 2024
14 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5/valid branch December 10, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli