API Make LinkFieldController a subclass of FormSchemaController #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/5/formschema
branch
from
bc92ed1 to
e52f39a
Compare
GuySartorelli
commented
Nov 14, 2024
Comment on lines
-254
to
+256
| // Will end up at an HTML page with "Silverstripe - Bad Request" | ||
| $this->assertSame('text/html; charset=utf-8', $response->getHeader('Content-type')); | ||
| $this->assertStringContainsString('Silverstripe - Bad Request', $response->getBody()); | ||
| // Gives suitable error message for XHR request | ||
| $this->assertStringStartsWith('text/plain', $response->getHeader('Content-type')); | ||
| $this->assertStringContainsString('There seems to have been a technical problem', $response->getBody()); |
There was a problem hiding this comment.
The modal links used to be routed through LeftAndMain which meant the error handling in that class was used. For some reason they weren't picked up as XHR requests so the full HTML error page was being rendered which wasn't really the correct behaviour, but it's what happened.
Now, a simple 400 response (the default one produced when a form's CSRF token is missing) is produced and isn't altered. This is the correct behaviour.
The end result for the user is no change.
emteknetnz
approved these changes
Nov 14, 2024
emteknetnz
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs silverstripe/silverstripe-admin#1850 for CI to go green. Please merge that first.
Issue
LeftAndMaininto its own abstract class silverstripe-admin#1762