Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Call updated method #347

Merged
merged 1 commit into from
Nov 11, 2024
Merged

FIX Call updated method #347

merged 1 commit into from
Nov 11, 2024

Conversation

emteknetnz
Copy link
Member

Issue #346

@emteknetnz emteknetnz mentioned this pull request Nov 11, 2024
Closed
@emteknetnz emteknetnz marked this pull request as ready for review November 11, 2024 02:46
GuySartorelli
GuySartorelli requested changes Nov 11, 2024
View reviewed changes
src/Form/AbstractLinkField.php Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/5/namespace-factory branch from 37aa714 to 0632428 Compare November 11, 2024 22:21
GuySartorelli
GuySartorelli approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 06636c4 into silverstripe:5 Nov 11, 2024
11 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5/namespace-factory branch November 11, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli