Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX FileLink does not own the File #341

Conversation

UndefinedOffset
Copy link

Description

The FileLink link type does not own it's file so when the link is published either through a recursive publish or directly the file itself is left in draft.

Manual testing steps

  1. Have a Link as either a has_one or has_many relationship on an object that owns the link relationship.
  2. Then add a file link to a newly uploaded file which will be then in draft only. If the object with the link relationship is versioned publish the object if not save.
  3. Verify the file is now published

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

@UndefinedOffset UndefinedOffset changed the base branch from 4 to 4.0 September 27, 2024 18:22
@UndefinedOffset
Copy link
Author

closing per comments in #340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant