Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: asset-admin is a suggested, not required module #203

Closed
wants to merge 1 commit into from
Closed

FIX: asset-admin is a suggested, not required module #203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
}
],
"require": {
"silverstripe/framework": "~4",
"silverstripe/framework": "~4"
},
"suggest": {
"silverstripe/asset-admin": "~1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"silverstripe/asset-admin": "~1"
"silverstripe/asset-admin": "Provides an admin interface for managing your Silverstripe assets"

The suggest schema is key => value: module => description

Copy link
Member Author

@sminnee sminnee Sep 10, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, good point. I think I might rewrite it to say "Necessary to make use of bulk-upload features." ie to explain why we're suggesting that module.

},
"extra": {
Expand Down