FIX: asset-admin is a suggested, not required module #203
Conversation
This lets you install the module in apps that don’t have asset-admin (such as ModelAdmin-focused apps, where batch editing would be handy) Fixes #202.
|
Any thoughts on this? |
|
@robbieaverill @colymba do you think that this will cause issues for people who expect to have asset-admin pulled in for them? I'd note that I haven't tested this module on an installation lacking asset-admin, and while I'd like to, it's difficult to pull it into a project without this PR. |
|
It's a tricky thing to answer really, because this module provides two equally valuable features: bulk uploading, and bulk editing. If you use this for the bulk uploading then maybe you would expect asset-admin to be installed. I have a feeling that people are more likely to install this on a full Silverstripe installation though, so this PR seems sensible to me. |
| "silverstripe/framework": "~4", | ||
| "silverstripe/framework": "~4" | ||
| }, | ||
| "suggest": { | ||
| "silverstripe/asset-admin": "~1" |
There was a problem hiding this comment.
| "silverstripe/asset-admin": "~1" | |
| "silverstripe/asset-admin": "Provides an admin interface for managing your Silverstripe assets" |
The suggest schema is key => value: module => description
There was a problem hiding this comment.
Right, good point. I think I might rewrite it to say "Necessary to make use of bulk-upload features." ie to explain why we're suggesting that module.
|
Just had a look through the codebase. There's one concrete reference to |
|
Fair enough, the assumption was that BulkUploadHandler wouldn't be used on a project without AssetAdmin, but it can probably be patched to provide an error message to that effect if you try and use it. |
This lets you install the module in apps that don’t have asset-admin
(such as ModelAdmin-focused apps, where batch editing would be handy)
Fixes #202.