-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: NestedInputBuilder doesn't work with nested '*' #538
FIX: NestedInputBuilder doesn't work with nested '*' #538
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add an additional test to check the case that was stated in the initial issue.
I thought the answer was going to be "yes, easy peasy" but it turns out that there's something weird about the way test schemas are built which differs in some way from normal schemas.... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@GuySartorelli, I've already approved. I couldn't reproduce issue by using provided code example in main ticket. But I have a question regarding new issue that you opened. |
Did you use this example and did you both activate the default schema and tell graphql where to look for your models file?
That's actually exactly the problem. In that issue, the schema example doesn't cause any exception when used outside of a test context. But when used in a test, it gets the exception mentioned in that issue - which is indeed a different exception than the one this PR is fixing. So there's something about the way tests set up or build schemas that's different from the normal execution, which is causing that exception when no exception should be thrown. |
|
Supercedes #536 and includes requested changes mentioned in that PR
Issue