Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Change type to Int #206

Merged

Conversation

emteknetnz
Copy link
Member

Issue silverstripe/silverstripe-framework#11408

Elsewhere in the file it is set and tested as an int, causes a ValidationException to be thrown on dev build

@emteknetnz emteknetnz marked this pull request as draft October 10, 2024 21:19
@emteknetnz emteknetnz force-pushed the pulls/2/field-validators branch from 84b65f2 to 9b81722 Compare October 21, 2024 05:29
@emteknetnz emteknetnz marked this pull request as ready for review October 21, 2024 21:33
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge when all PRs are ready

@emteknetnz emteknetnz force-pushed the pulls/2/field-validators branch from 9b81722 to 020bbb0 Compare November 5, 2024 00:23
@GuySartorelli GuySartorelli merged commit 4ecbf4a into silverstripe:2 Nov 6, 2024
1 check passed
@GuySartorelli GuySartorelli deleted the pulls/2/field-validators branch November 6, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants