Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Call validate on form fields within form #11506

Conversation

emteknetnz
Copy link
Member

Issue #10908

@emteknetnz emteknetnz mentioned this pull request Dec 11, 2024
8 tasks
@emteknetnz emteknetnz force-pushed the pulls/6.0/remove-fieldsvalidator branch 2 times, most recently from e9ac595 to c055a1e Compare December 11, 2024 02:38
@emteknetnz emteknetnz marked this pull request as ready for review December 11, 2024 20:28
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One very tiny change

src/Forms/Form.php Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/6.0/remove-fieldsvalidator branch from c055a1e to 283d69a Compare December 11, 2024 21:20
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 45d2b64 into silverstripe:6.0 Dec 12, 2024
8 of 12 checks passed
@GuySartorelli GuySartorelli deleted the pulls/6.0/remove-fieldsvalidator branch December 12, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants