Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Config to toggle allowing whitespace only in Requiredfields #11491

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Dec 3, 2024

Issue #10908

Unit test failures are unrelated

@emteknetnz emteknetnz mentioned this pull request Dec 3, 2024
8 tasks
@emteknetnz emteknetnz force-pushed the pulls/5/allow-ws-only branch from 99f9400 to d20bce5 Compare December 3, 2024 23:27
@emteknetnz emteknetnz marked this pull request as ready for review December 4, 2024 22:06
src/Forms/RequiredFields.php Outdated Show resolved Hide resolved
tests/php/Forms/RequiredFieldsTest.php Outdated Show resolved Hide resolved
tests/php/Forms/RequiredFieldsTest.php Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/5/allow-ws-only branch from d20bce5 to 63caeef Compare December 5, 2024 03:26
src/Forms/RequiredFields.php Outdated Show resolved Hide resolved
src/Forms/RequiredFields.php Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/5/allow-ws-only branch from 63caeef to beaefae Compare December 5, 2024 21:14
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit b662f03 into silverstripe:5 Dec 5, 2024
14 of 17 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5/allow-ws-only branch December 5, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants