Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Add deprecation #11427

Merged
merged 1 commit into from
Oct 20, 2024
Merged

API Add deprecation #11427

merged 1 commit into from
Oct 20, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Oct 15, 2024 •
edited
Loading

Issue #11403

DBField::getDefaultValue() will simply return DBField.defaultVal

In the CMS 6 PR I've changed protected $defaultVal; to private mixed $defaultValue = null;

@emteknetnz emteknetnz mentioned this pull request Oct 15, 2024
Closed
10 tasks
@emteknetnz emteknetnz force-pushed the pulls/5/field-validator-depr branch from baeaef4 to 8ec068f Compare October 17, 2024 03:06
GuySartorelli
GuySartorelli approved these changes Oct 20, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, always good to get people using the getter/setter 👍

@GuySartorelli GuySartorelli merged commit 969d7b4 into silverstripe:5 Oct 20, 2024
14 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5/field-validator-depr branch October 20, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli