You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The IPUtils class is a direct copy from the class of the same name in symfony/http-foundation.
We should deprecate our class, and just include symfony/http-foundation as a direct dependency, directing people to use it instead.
Reasoning
Currently some of our methods in that class are out of date, and don't have improvements Symfony has made. Using their package directly obviously keeps it up to date.
We're left maintaining code that someone else is already maintaining. That's just silly.
In general, there's a desire currently to offload more of our code to third-party libraries which are more mature and better situated to maintain that code. This aligns with that desire.
Acceptance criteria
Remove the old code and replace it with symfony dependency
Deprecate any code as necessary in CMS 5
If we can simply swap it out and no unit tests break, then do the work directly in CMS 5 instead. Otherwise if we need to update the code that calls these methods, then target CMS 6
The IPUtils class is a direct copy from the class of the same name in symfony/http-foundation.
We should deprecate our class, and just include
symfony/http-foundation
as a direct dependency, directing people to use it instead.Reasoning
Acceptance criteria
CMS 5 PRs
CMS 6 PRs
The text was updated successfully, but these errors were encountered: