FIX Call defineMethods if lower method is missing

silverstripe · Oct 21, 2024 · ba5f55e · ba5f55e
1 parent ba97de9
commit ba5f55e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/Core/CustomMethods.php b/src/Core/CustomMethods.php
@@ -171,11 +171,14 @@ protected function getExtraMethodConfig($method)
         }
         // Lazy define methods
         $lowerClass = strtolower(static::class);
-        if (!isset(self::class::$extra_methods[$lowerClass])) {
+        $lowerMethod = strtolower($method);
+        if (!array_key_exists($lowerClass, self::class::$extra_methods)
+            || !array_key_exists($lowerMethod, self::class::$extra_methods[$lowerClass])
+        ) {
             $this->defineMethods();
         }
 
-        return self::class::$extra_methods[$lowerClass][strtolower($method)] ?? null;
+        return self::class::$extra_methods[$lowerClass][$lowerMethod] ?? null;
     }
 
     /**

diff --git a/tests/php/Dev/DeprecationTest.php b/tests/php/Dev/DeprecationTest.php
@@ -111,7 +111,7 @@ public function testNoticeNoReplacement()
             'Will be removed without equivalent functionality to replace it.',
             'Called from SilverStripe\Dev\Tests\DeprecationTest->testNoticeNoReplacement.'
         ]);
-        $this->expectDeprecation();
+        $this->expectException(DeprecationTestException::class);
         $this->expectDeprecationMessage($message);
         $this->enableDeprecationNotices(true);
         $ret = $this->myDeprecatedMethodNoReplacement();