Merge branch '3' into 4

silverstripe · Sep 19, 2024 · cba331d · cba331d
2 parents 417299c + bce020b
commit cba331d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/Tasks/CheckExternalLinksTask.php b/src/Tasks/CheckExternalLinksTask.php
@@ -187,7 +187,7 @@ public function runLinksCheck($limit = null)
 
             // Check value of html area
             $page = $pageTrack->Page();
-            Deprecation::withNoReplacement(fn() => $this->log("Checking {$page->Title}"));
+            Deprecation::withSuppressedNotice(fn() => $this->log("Checking {$page->Title}"));
             $htmlValue = Injector::inst()->create(HTMLValue::class, $page->Content);
             if (!$htmlValue->isValid()) {
                 continue;
@@ -205,15 +205,15 @@ public function runLinksCheck($limit = null)
             try {
                 $page->write();
             } catch (ValidationException $ex) {
-                Deprecation::withNoReplacement(function () use ($page, $ex) {
+                Deprecation::withSuppressedNotice(function () use ($page, $ex) {
                     $this->log("Exception caught for {$page->Title}, skipping. Message: " . $ex->getMessage());
                 });
                 continue;
             }
 
             // Once all links have been created for this page update HasBrokenLinks
             $count = $pageTrack->BrokenLinks()->count();
-            Deprecation::withNoReplacement(fn() => $this->log("Found {$count} broken links"));
+            Deprecation::withSuppressedNotice(fn() => $this->log("Found {$count} broken links"));
             if ($count) {
                 $siteTreeTable = DataObject::getSchema()->tableName(SiteTree::class);
                 // Bypass the ORM as syncLinkTracking does not allow you to update HasBrokenLink to true

diff --git a/tests/php/ExternalLinksTest.php b/tests/php/ExternalLinksTest.php
@@ -37,7 +37,7 @@ public function testLinks()
     {
         // Run link checker
         $task = CheckExternalLinksTask::create();
-        Deprecation::withNoReplacement(fn() => $task->setSilent(true)); // Be quiet during the test!
+        Deprecation::withSuppressedNotice(fn() => $task->setSilent(true)); // Be quiet during the test!
         $task->runLinksCheck();
 
         // Get all links checked
@@ -114,7 +114,7 @@ public function testArchivedPagesAreHiddenFromReport()
     {
         // Run link checker
         $task = CheckExternalLinksTask::create();
-        Deprecation::withNoReplacement(fn() => $task->setSilent(true)); // Be quiet during the test!
+        Deprecation::withSuppressedNotice(fn() => $task->setSilent(true)); // Be quiet during the test!
         $task->runLinksCheck();
 
         // Ensure report lists all broken links