ENH Convert ElementList into a functional component #1297
Merged
+152
−165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/6.0/elementlist-functional
branch
2 times, most recently
from
5b4f3fa to
6faa3c2
Compare
|
behat failure will be fixed by #1296 separately |
emteknetnz
requested changes
Dec 16, 2024
| increment | ||
| }); | ||
| // These state setting methods are set by the ElementList react component | ||
| // setting saveAllElementst state to true will trigger a re-render in the react component |
There was a problem hiding this comment.
Suggested change
| // setting saveAllElementst state to true will trigger a re-render in the react component | |
| // setting saveAllElements state to true will trigger a re-render in the react component |
GuySartorelli
force-pushed
the
pulls/6.0/elementlist-functional
branch
from
6faa3c2 to
b4b13dc
Compare
emteknetnz
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to allow the use of hooks for dnd-kit.
This PR should change nothing about the user experience or functionality of the module, it should be a perfect like-for-like comparison to
6.0without this PR.Test everything you can think to test - sorting, saving, publishing, archiving, etc both from a page and an element level to check everything works the way it used to.
Issue