Fix ensure blocks array not null before component update #1294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure
blocks
properties inElementList::componentDidUpdate
are not null before callingmap
method. This is to prevent breaking the elemental area field while it is rendering, and the content author clicks the save or publish buttons too quickly.Manual testing steps
/admin/graphql
for each elemental areacancelled
. The requests may load fast, which makes it hard to replicate. I edited the controllerSilverStripe\GraphQL\Controller
, and addedsleep(1);
toindex
method to slow down the request.map
on null, must not be throwing in the consoleIssues
Pull request checklist