Merge pull request #263 from creative-commoners/pulls/6/field-validators

FIX Set empty date to null
silverstripe · Nov 6, 2024 · a62fd3c · a62fd3c
2 parents 1bce10d + 7c9420d
commit a62fd3c
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/src/Extensions/SiteTreeContentReview.php b/src/Extensions/SiteTreeContentReview.php
@@ -194,7 +194,7 @@ protected function updateCMSActions(FieldList $actions)
      *
      * @param SiteTree $page
      *
-     * @return bool|DBDate
+     * @return null|DBDate
      */
     public function getReviewDate(SiteTree $page = null)
     {
@@ -209,11 +209,11 @@ public function getReviewDate(SiteTree $page = null)
         $options = $this->owner->getOptions();
 
         if (!$options) {
-            return false;
+            return null;
         }
 
         if (!$options->ReviewPeriodDays) {
-            return false;
+            return null;
         }
 
         // Failover to check on ReviewPeriodDays + LastEdited
@@ -508,7 +508,6 @@ public function advanceReviewDate()
                 ' + ' . $options->ReviewPeriodDays . ' days',
                 DBDatetime::now()->getTimestamp()
             );
-
             $this->owner->NextReviewDate = DBDate::create()->setValue($nextDateTimestamp)->Format(DBDate::ISO_DATE);
             $this->owner->write();
         }