Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulls/4.0/5464 duplicate campaign name #17

Conversation

phalkunz
Copy link
Contributor

@phalkunz phalkunz commented May 5, 2017

@phalkunz phalkunz force-pushed the pulls/4.0/5464-duplicate-campaign-name branch 3 times, most recently from 3b75f3e to 6e357c5 Compare May 5, 2017 00:19

$message = _t('LeftAndMain.SAVEDUP', 'Saved.');
$hasExistingName = Changeset::get()
->filter('Name:case', $data['Name'])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would opt for case-insensitivity when filtering for a duplicate.
Having an entry My case and allowing for My Case to also be created is going to be confusing.

Was this discussed to have it case-sensitive?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it wasn't in any discussion. I thought it was a good idea but in hindsight it is rather confusing. Good spotting it :)

@phalkunz phalkunz force-pushed the pulls/4.0/5464-duplicate-campaign-name branch from 6e357c5 to 40546cc Compare May 9, 2017 21:55
@flamerohr flamerohr merged commit d081aec into silverstripe:master May 9, 2017
@flamerohr flamerohr deleted the pulls/4.0/5464-duplicate-campaign-name branch May 9, 2017 22:07
dnsl48 pushed a commit to creative-commoners/silverstripe-campaign-admin that referenced this pull request Oct 29, 2020
Add PHP7 + SS3.6 build to Travis configuration and fix build badge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants