Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Replace Extension subclasses #780

Merged
merged 1 commit into from
Aug 28, 2024
Merged

API Replace Extension subclasses #780

merged 1 commit into from
Aug 28, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request Aug 20, 2024
Closed
@emteknetnz emteknetnz force-pushed the pulls/5/replace-extension-subclasses branch from e2b8c85 to 6799b18 Compare August 28, 2024 00:28
GuySartorelli
GuySartorelli reviewed Aug 28, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge when PRs removing classes have been merged

GuySartorelli
GuySartorelli approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually just realised I can just merge this one now without side effects.

@GuySartorelli GuySartorelli merged commit 6926f98 into silverstripe:5 Aug 28, 2024
10 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5/replace-extension-subclasses branch August 28, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli