Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT ESLint issues #714

Merged
merged 1 commit into from
Jul 9, 2023
Merged

MNT ESLint issues #714

merged 1 commit into from
Jul 9, 2023

Conversation

sabina-talipova
Copy link
Contributor

Description

Turn on some of the ESLint.

Parent issue

@sabina-talipova sabina-talipova marked this pull request as draft June 28, 2023 02:35
@sabina-talipova sabina-talipova mentioned this pull request Jun 28, 2023
Closed
2 tasks
@sabina-talipova sabina-talipova marked this pull request as ready for review July 3, 2023 02:16
@sabina-talipova sabina-talipova force-pushed the pulls/4/turn-on-eslint-rules branch from e7fdcae to 39c330a Compare July 4, 2023 23:56
@sabina-talipova
Copy link
Contributor Author

Failed Behat tests are unrelated to changes that has been done.

emteknetnz
emteknetnz requested changes Jul 5, 2023
View reviewed changes
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing tests

@sabina-talipova
Copy link
Contributor Author

Only one indent rule was applied in this file, which should not cause this problem. When I test it manually there is no problem.

@sabina-talipova sabina-talipova force-pushed the pulls/4/turn-on-eslint-rules branch 2 times, most recently from f8b5c04 to e6b1e95 Compare July 6, 2023 04:04
emteknetnz
emteknetnz requested changes Jul 6, 2023
View reviewed changes
Copy link
Member

@emteknetnz emteknetnz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the commit and PR prefix from FIX to MNT

@sabina-talipova sabina-talipova changed the title FIX ESLint issues MNT ESLint issues Jul 7, 2023
@sabina-talipova sabina-talipova force-pushed the pulls/4/turn-on-eslint-rules branch from e6b1e95 to 57def71 Compare July 7, 2023 03:53
@emteknetnz emteknetnz merged commit 84b815d into silverstripe:4 Jul 9, 2023
@emteknetnz emteknetnz deleted the pulls/4/turn-on-eslint-rules branch July 9, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabina-talipova @emteknetnz