Skip to content

Commit

Permalink
Merge pull request #252 from creative-commoners/pulls/5.0/remove-todo
Browse files Browse the repository at this point in the history
MNT Remove TODO comments
  • Loading branch information
GuySartorelli authored Oct 24, 2023
2 parents 1a2c5fe + dc98f28 commit 86c6c81
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 0 additions & 2 deletions src/Context/FixtureContext.php
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,6 @@ public function stepCreateRecordWithTable($type, $id, TableNode $fieldsTable)
{

$class = $this->convertTypeToClass($type);
// TODO Support more than one record
$fields = $this->convertFields($class, $fieldsTable->getRowsHash());
$fields = $this->prepareFixture($class, $id, $fields);

Expand Down Expand Up @@ -522,7 +521,6 @@ public function stepThereAreTheFollowingRecords($dataObject, PyStringNode $strin
$yaml = implode("\n ", $yaml);

// Save fixtures into database
// TODO Run prepareAsset() for each File and Folder record
$yamlFixture = new YamlFixture($yaml);
$yamlFixture->writeInto($this->getFixtureFactory());
}
Expand Down
2 changes: 1 addition & 1 deletion src/Controllers/ModuleSuiteLocator.php
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ protected function loadSuiteConfiguration($suite, Module $module)
// Resolve variables
$resolvedConfig = $this->container->getParameterBag()->resolveValue($suiteConfig);
return [
'type' => null, // @todo figure out what this is for
'type' => null,
'settings' => $resolvedConfig,
];
}
Expand Down

0 comments on commit 86c6c81

Please sign in to comment.