Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Use extension hook instead of proxy-db #75

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Apr 28, 2024

Issue #73

Requires silverstripe/silverstripe-framework#11209

To test logging, put something like this in AuditFactory::create():40

// don't merge this
$log->pushHandler(new \Monolog\Handler\StreamHandler('/var/www/out.txt'));

Then login an as an admin and create a new member - you should see a "modified Member" row added in the log

Copy link
Contributor

@sabina-talipova sabina-talipova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Test locally. Work as expected.

@sabina-talipova sabina-talipova merged commit b115bc7 into silverstripe:4 Apr 29, 2024
12 checks passed
@sabina-talipova sabina-talipova deleted the pulls/4/hook branch April 29, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants