Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Use correct namespace for session manager controller #74

Merged

Conversation

emteknetnz
Copy link
Member

Issue #55

The unit test hasn't run for a long time because the extension wasn't being attached. The unit test fails, because the logic has since been updated so sessions can only be removed by the user who the LoginSession belongs to

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit d72b429 into silverstripe:3 Apr 25, 2024
12 checks passed
@GuySartorelli GuySartorelli deleted the pulls/3/fix-namespace branch April 25, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants