Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Update validation methods #648

Merged
merged 1 commit into from
Nov 6, 2024
Merged

API Update validation methods #648

merged 1 commit into from
Nov 6, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz force-pushed the pulls/3/field-validators branch 2 times, most recently from b65c503 to b7d9392 Compare October 2, 2024 02:23
@emteknetnz emteknetnz mentioned this pull request Oct 2, 2024
Closed
10 tasks
@emteknetnz emteknetnz force-pushed the pulls/3/field-validators branch from b7d9392 to fb83b19 Compare October 2, 2024 02:26
@emteknetnz emteknetnz changed the title API Rename method API Update validation methods Oct 2, 2024
@emteknetnz emteknetnz force-pushed the pulls/3/field-validators branch 2 times, most recently from bc26128 to e092f51 Compare October 2, 2024 03:02
@emteknetnz emteknetnz force-pushed the pulls/3/field-validators branch 2 times, most recently from c28b13f to 3745981 Compare October 21, 2024 05:31
@emteknetnz emteknetnz marked this pull request as ready for review October 21, 2024 21:33
GuySartorelli
GuySartorelli approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem related but it's an objectively good change. LGTM, will merge when all PRs are ready.

@emteknetnz emteknetnz force-pushed the pulls/3/field-validators branch from 3745981 to ca8149d Compare October 31, 2024 02:33
@GuySartorelli GuySartorelli merged commit 1bc842d into silverstripe:3 Nov 6, 2024
7 checks passed
@GuySartorelli GuySartorelli deleted the pulls/3/field-validators branch November 6, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli