-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Remove silverstripe/campaign-admin integration support #1857
API Remove silverstripe/campaign-admin integration support #1857
Conversation
00dcb1d
to
75be91c
Compare
75be91c
to
700f898
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i18n._t('CampaignAdmin.DELETECAMPAIGN', 'Are you sure you want to delete this record?')
in client/src/components/GridField/GridField.js
should not use a localisation key from campaign admin. There's a few others in that file too.
- Double check if that is actually at all related to campaign functionality and if so, update the logic as needed
- Use a localisation key that doesn't have anything to do with campaigns
I don't actually know what this react component for GridField even does, or if it's even used (I suspect it isn't) Perhaps this one should be a new card to work out if we should just delete the file, along with the seemingly associated GridFieldActions.js? |
7a886f1
to
ee2955b
Compare
Looks like That said, if you want to remove that in a separate card I'm okay with that. Up to you. Either way, this needs a rebase. |
Will do as new card |
ee2955b
to
9e393ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue silverstripe/.github#342