Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Remove silverstripe/campaign-admin integration support #1857

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Nov 20, 2024

@emteknetnz emteknetnz force-pushed the pulls/3/remove-support branch from 00dcb1d to 75be91c Compare November 25, 2024 01:32
@emteknetnz emteknetnz force-pushed the pulls/3/remove-support branch from 75be91c to 700f898 Compare November 26, 2024 04:13
@emteknetnz emteknetnz marked this pull request as ready for review November 26, 2024 04:32
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i18n._t('CampaignAdmin.DELETECAMPAIGN', 'Are you sure you want to delete this record?') in client/src/components/GridField/GridField.js should not use a localisation key from campaign admin. There's a few others in that file too.

  1. Double check if that is actually at all related to campaign functionality and if so, update the logic as needed
  2. Use a localisation key that doesn't have anything to do with campaigns

@emteknetnz
Copy link
Member Author

I don't actually know what this react component for GridField even does, or if it's even used (I suspect it isn't)

Perhaps this one should be a new card to work out if we should just delete the file, along with the seemingly associated GridFieldActions.js?

@emteknetnz emteknetnz force-pushed the pulls/3/remove-support branch 2 times, most recently from 7a886f1 to ee2955b Compare November 27, 2024 02:15
@GuySartorelli
Copy link
Member

Looks like Gridfield.js is specifically the component for the gridfield-like UI in campaign admin. Almost certainly not used anywhere else in core.

That said, if you want to remove that in a separate card I'm okay with that. Up to you.

Either way, this needs a rebase.

@emteknetnz
Copy link
Member Author

Will do as new card

@emteknetnz emteknetnz force-pushed the pulls/3/remove-support branch from ee2955b to 9e393ca Compare November 27, 2024 22:10
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 00061b1 into silverstripe:3 Nov 28, 2024
12 checks passed
@GuySartorelli GuySartorelli deleted the pulls/3/remove-support branch November 28, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants