Expand injector form API to be more state aware with FormStateManager #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclecheese
force-pushed
the
pulls/1.0/injector-form-state-awareness
branch
from
b299ee2 to
dbf7b80
Compare
flamerohr
reviewed
Aug 1, 2017
| */ | ||
| mutateField(fieldName, updater) { | ||
| const fieldList = this.schemaState.fields || []; | ||
| const fieldList = this.schema.state.fields || []; | ||
| const fieldIndex = fieldList.findIndex(field => field.name === fieldName); | ||
| if (fieldIndex < 0) { | ||
| return this; | ||
| } | ||
| const field = fieldList[fieldIndex]; |
There was a problem hiding this comment.
just noticed this should be { ...fieldList[fieldIndex] } or below have updater({ ...field }) in case of mutations in the updater()
| */ | ||
| constructor(schemaState) { | ||
| this.schemaState = { ...schemaState }; | ||
| constructor(schema, reduxFormState) { |
There was a problem hiding this comment.
missing JSDoc for reduxFormState
added 2 commits
August 2, 2017 10:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for silverstripe/silverstripe-campaign-admin#16
Resolves: silverstripe/silverstripe-framework#7226