Skip to content

Commit

Permalink
FIX jsx-a11y rules
Browse files Browse the repository at this point in the history
  • Loading branch information
Sabina Talipova committed Jul 7, 2023
1 parent c5d99bc commit c6cb2aa
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 6 deletions.
1 change: 1 addition & 0 deletions client/src/boot/BootRoutes.js
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,7 @@ class BootRoutes {
// events that should be caught by react component event handlers.
// Note that this empty link is rendered into an element that doesn't exist in the DOM.
const root = createRoot(document.createElement('div'));
// eslint-disable-next-line jsx-a11y/anchor-has-content, jsx-a11y/anchor-is-valid
root.render(<a role="none" onClick={() => {}} />);

// Start the page router
Expand Down
1 change: 1 addition & 0 deletions client/src/components/IframeDialog/IframeDialog.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable jsx-a11y/iframe-has-title */
import React, { Component } from 'react';
import { Modal, ModalHeader, ModalBody } from 'reactstrap';
import classnames from 'classnames';
Expand Down
1 change: 1 addition & 0 deletions client/src/components/ListGroup/ListGroupItem.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ class ListGroupItem extends Component {
render() {
const className = `list-group-item ${this.props.className}`;
return (
// eslint-disable-next-line jsx-a11y/anchor-is-valid
<a role="button" tabIndex={0} className={className} onClick={this.handleClick}>
{this.props.children}
</a>
Expand Down
15 changes: 9 additions & 6 deletions client/src/components/Preview/Preview.js
Original file line number Diff line number Diff line change
Expand Up @@ -123,12 +123,15 @@ class Preview extends Component {
}

// Show iframe preview
return (<iframe
style={{ visibility: this.state.frameLoaded ? 'visible' : 'hidden' }}
className="flexbox-area-grow preview__iframe"
src={previewUrl}
onLoad={this.setFrameLoaded}
/>);
return (
// eslint-disable-next-line jsx-a11y/iframe-has-title
<iframe
style={{ visibility: this.state.frameLoaded ? 'visible' : 'hidden' }}
className="flexbox-area-grow preview__iframe"
src={previewUrl}
onLoad={this.setFrameLoaded}
/>
);
}

render() {
Expand Down

0 comments on commit c6cb2aa

Please sign in to comment.