Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Move graphql tests out of recipe-cms #69

Merged
merged 2 commits into from
Sep 2, 2024
Merged

MNT Move graphql tests out of recipe-cms #69

merged 2 commits into from
Sep 2, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request Aug 4, 2024
Closed
11 tasks
@emteknetnz emteknetnz force-pushed the pulls/6/move-graphql branch from ab43dab to 6c75414 Compare August 6, 2024 21:35
@emteknetnz emteknetnz marked this pull request as ready for review August 19, 2024 22:14
GuySartorelli
GuySartorelli approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge once the other PRs are ready

GuySartorelli
GuySartorelli requested changes Aug 20, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually just noticed. Don't we need to add graphql do the recipe-kitchen-sink deps in composer.json?

@emteknetnz emteknetnz force-pushed the pulls/6/move-graphql branch from 6c75414 to 1b7d605 Compare August 21, 2024 03:39
@emteknetnz
Copy link
Member Author

Yes :-) Added

@emteknetnz emteknetnz force-pushed the pulls/6/move-graphql branch from 1b7d605 to 000abe1 Compare August 22, 2024 00:57
GuySartorelli
GuySartorelli approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approved

@GuySartorelli GuySartorelli merged commit e2bb274 into silverstripe:6 Sep 2, 2024
58 checks passed
@GuySartorelli GuySartorelli deleted the pulls/6/move-graphql branch September 2, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli