Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP Remove cwp/agency-extensions #54

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Feb 26, 2024

Issue silverstripe/.github#199

There is no CMS 6 version of cwp/cwp which means cwp/agency-extensions will never be CMS 6 compatible, so we're simply removing it from sink

CI failures are existing and unrelated to this PR

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Don't forget to delete the branch that was added to agency-extensions

@GuySartorelli
Copy link
Member

CI failures in sink are expected at this stage - ignoring CI.

@GuySartorelli GuySartorelli merged commit 1158a7c into silverstripe:6 Feb 26, 2024
5 of 22 checks passed
@GuySartorelli GuySartorelli deleted the pulls/6/remove-agency-extensions branch February 26, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants