Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Use php 7.4 for prefer-lowest #18

Merged

Conversation

emteknetnz
Copy link
Member

Issue silverstripe/gha-ci#37

Fix https://github.com/silverstripe/recipe-kitchen-sink/runs/7512733988?check_suite_focus=true
Problem 1 - Root composer.json requires php ^7.4 || ^8.0 but your php version (7.3; overridden via config.platform, actual: 7.3.33) does not satisfy that requirement.

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to have to update these every release that changes PHP versions?
Is there a way to add these jobs without having to define the PHP versions in here?

@emteknetnz
Copy link
Member Author

Nope. It's really not a big deal though, probably only one more release on the 4.x line and I'm not sure if we'd drop 7.4 at that point

@GuySartorelli
Copy link
Member

Does that mean for the 5.x line we'll be doing something different? My main worry is that we'll forget to update this since we don't change PHP versions very often.

@emteknetnz
Copy link
Member Author

Build will break because the version of PHP is too low for what composer.json accepts so we'll know. That's how I knew for this one.

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I guess.... it's not great but it works for now so I'll merge it and we can look at reworking this if it becomes a burden down the line.

@GuySartorelli GuySartorelli merged commit 7ce7c9c into silverstripe:4.11 Jul 27, 2022
@GuySartorelli GuySartorelli deleted the pulls/4.11/preflow branch July 27, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants