MNT Use frameworktest ^2 #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
emteknetnz
force-pushed
the
pulls/3/frameworktest
branch
from
55aee7f to
f048e81
Compare
emteknetnz
force-pushed
the
pulls/3/frameworktest
branch
from
f048e81 to
b0a4318
Compare
GuySartorelli
requested changes
Feb 26, 2024
composer.json
Outdated
| @@ -14,7 +14,8 @@ | |||
| "require-dev": { | |||
| "phpunit/phpunit": "^9.6", | |||
| "silverstripe/gridfieldqueuedexport": "^4", | |||
| "symbiote/silverstripe-queuedjobs": "^6" | |||
| "symbiote/silverstripe-queuedjobs": "^6", | |||
| "silverstripe/frameworktest": "^2" | |||
There was a problem hiding this comment.
Suggested change
| "silverstripe/frameworktest": "^2" |
We intentionally don't add this to recipes - people can composer create-project silverstripe/recipe-blog and we don't want them getting frameworktest in their project dependencies.
That's why it was added to ci.yml in the first place. Add it back there with the correct constraint, and add a comment so we don't try to do this again.
emteknetnz
force-pushed
the
pulls/3/frameworktest
branch
from
b0a4318 to
39ae9f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/.github#199
Fixes https://github.com/silverstripe/recipe-blog/actions/runs/8014497893/job/21893244725#step:9:300
Root composer.json requires silverstripe/frameworktest ^1 -> satisfiable by silverstripe/frameworktest[1.x-dev].