FIX Allow different node versions for admin vs module #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
requested changes
Jul 19, 2022
action.yml
Outdated
| nvm install | ||
| nvm use | ||
| rm -rf client/dist | ||
| if [[ $(npm -v) != $NPM_VERSION ]]; then |
There was a problem hiding this comment.
Have initialised the variable above.
There was a problem hiding this comment.
set NPM_VERSION= above the if [[ -d vendor/silverstripe/admin ]]; then block in-case there is no admin dir
It ?might? work in bash as it is now, though it's weird and confusing
There was a problem hiding this comment.
And change the var name to ADMIN_NPM_VERSION
GuySartorelli
force-pushed
the
pulls/1.0/allow-multiple-node-versions
branch
from
0714c90 to
e896563
Compare
emteknetnz
requested changes
Jul 19, 2022
action.yml
Outdated
| nvm install | ||
| nvm use | ||
| rm -rf client/dist | ||
| if [[ $(npm -v) != $NPM_VERSION ]]; then |
There was a problem hiding this comment.
set NPM_VERSION= above the if [[ -d vendor/silverstripe/admin ]]; then block in-case there is no admin dir
It ?might? work in bash as it is now, though it's weird and confusing
GuySartorelli
force-pushed
the
pulls/1.0/allow-multiple-node-versions
branch
from
e896563 to
bd1f72e
Compare
emteknetnz
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the module to have a different version of node than admin
Allows a fix for https://github.com/silverstripe/silverstripe-contentreview/runs/7401209441?check_suite_focus=true
Parent issue