NEW Create action #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/1/action
branch
from
0710ae8 to
1acead0
Compare
2 tasks
emteknetnz
force-pushed
the
pulls/1/action
branch
2 times, most recently
from
b3633e5 to
96d9058
Compare
GuySartorelli
requested changes
Jul 17, 2023
emteknetnz
force-pushed
the
pulls/1/action
branch
2 times, most recently
from
950cdc9 to
0fbcb5e
Compare
|
@GuySartorelli Have implemented peer review feedback Have tested updated code - works - https://github.com/emteknetnz/silverstripe-config/commits/2 |
emteknetnz
force-pushed
the
pulls/1/action
branch
2 times, most recently
from
41706fb to
a0cade2
Compare
|
There are still two unresolved conversations that you haven't responded to - please respond. |
|
Replied |
emteknetnz
force-pushed
the
pulls/1/action
branch
from
a0cade2 to
1f836fe
Compare
GuySartorelli
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue https://github.com/silverstripeltd/product-issues/issues/753
Example of it in action - https://github.com/emteknetnz/silverstripe-config/commits/2
Here's an example of it failing on merge-conflict - https://github.com/emteknetnz/silverstripe-config/actions/runs/5526914815/jobs/10082502001
Here's an example of it failing where there's a difference in composer.json - https://github.com/emteknetnz/silverstripe-config/actions/runs/5527199168/jobs/10082717263