You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
gha-merge-up currently does not support js files, instead it will fail any build that includes client/ in the files diff
ACs
Diffs that include client/ filter are allowed
If changes in the client/ are detected, for non silverstripe/admin modules, silverstripe/admin is installed in a sibling directory and yarn install is run (see gha-update-js for how to do this)
nvm use <correct_version> is run where correct_version is correct for the major version being merged-into
yarn build is run in the module being merged-up
The build fails if there is any issue with yarn build
Any updated dist files are git added
Initially, only asset-admin will use this functionality
Follow up issue from https://github.com/silverstripeltd/product-issues/issues/753
gha-merge-up currently does not support js files, instead it will fail any build that includes
client/
in the files diffACs
client/
filter are allowedclient/
are detected, for non silverstripe/admin modules, silverstripe/admin is installed in a sibling directory and yarn install is run (see gha-update-js for how to do this)nvm use <correct_version>
is run wherecorrect_version
is correct for the major version being merged-intoyarn build
is run in the module being merged-upyarn build
Follow up issues created
PRs
The text was updated successfully, but these errors were encountered: