Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gha-merge-up - Merge-up javascript #3

Closed
7 tasks
emteknetnz opened this issue Jul 12, 2023 · 1 comment
Closed
7 tasks

gha-merge-up - Merge-up javascript #3

emteknetnz opened this issue Jul 12, 2023 · 1 comment

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Jul 12, 2023

Follow up issue from https://github.com/silverstripeltd/product-issues/issues/753

gha-merge-up currently does not support js files, instead it will fail any build that includes client/ in the files diff

ACs

  • Diffs that include client/ filter are allowed
  • If changes in the client/ are detected, for non silverstripe/admin modules, silverstripe/admin is installed in a sibling directory and yarn install is run (see gha-update-js for how to do this)
  • nvm use <correct_version> is run where correct_version is correct for the major version being merged-into
  • yarn build is run in the module being merged-up
  • The build fails if there is any issue with yarn build
  • Any updated dist files are git added
  • Initially, only asset-admin will use this functionality

Follow up issues created

PRs

@GuySartorelli
Copy link
Member

PRs merged, all ACs met.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants