Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Require installer for recipe-blog #23

Merged
merged 1 commit into from
Jul 20, 2022
Merged

FIX Require installer for recipe-blog #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion consts.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,17 @@
'silverstripe-versioned-admin',
// recipe-solr-search doesn't include recipe-cms or recipe-core unlike our other recipes
'recipe-solr-search',
// recipe-blog requires a theme for the unit tests to work, the config and dependency for which are
// supplied by installer. Just adding a theme as a dev-dependency is insufficient because we'd still
// lack the yml config to activate that theme
'recipe-blog',
];

// Repositories that do not require silverstripe/installer to be explicitly added as a dependency for testing
const NO_INSTALLER_LOCKSTEPPED_REPOS = [
// these are/include recipe-cms or recipe-core, so we don't want to composer require installer
// in .travis.yml they used the 'self' provision rather than 'standard'
'recipe-authoring-tools',
'recipe-blog',
'recipe-ccl',
'recipe-cms',
'recipe-collaboration',
Expand Down