FIX Ensure silverstripe/config CI uses correct PHP versions #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failure is unrelated - that one's being fixed separately in #104 |
emteknetnz
requested changes
Aug 27, 2024
GuySartorelli
force-pushed
the
pulls/1.15/fix-config
branch
from
c480cad to
487b0e7
Compare
GuySartorelli
force-pushed
the
pulls/1.15/fix-config
branch
from
487b0e7 to
438cd03
Compare
|
Rebased so CI can go fully green |
emteknetnz
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/silverstripe/silverstripe-config/actions/runs/10499483113/job/29086335391
Turns out we've been using the CMS 4 PHP versions for config all along. We're only now seeing it fail because CMS 4 doesn't support PHP 8.3
Issue