Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Handle CMS 6 branches #12

Merged
merged 1 commit into from
Feb 22, 2024
Merged

ENH Handle CMS 6 branches #12

merged 1 commit into from
Feb 22, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request Feb 20, 2024
Closed
6 tasks
emteknetnz
emteknetnz commented Feb 20, 2024
View reviewed changes
action.yml Show resolved Hide resolved
GuySartorelli
GuySartorelli requested changes Feb 22, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, didn't notice this was still in pending.

action.yml Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/1.0/cms6 branch 4 times, most recently from 7a26fd9 to ad92ed1 Compare February 22, 2024 06:01
GuySartorelli
GuySartorelli requested changes Feb 22, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple of small changes.

action.yml Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
GuySartorelli
GuySartorelli approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 7138815 into silverstripe:1.0 Feb 22, 2024
4 checks passed
@GuySartorelli GuySartorelli deleted the pulls/1.0/cms6 branch February 22, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli