Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Allow recipe-testing ^4 #109

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Feb 23, 2024

@GuySartorelli
Copy link
Member

GuySartorelli commented Feb 23, 2024

Might as well just use * or >=2 at this point 😅

@emteknetnz
Copy link
Member Author

Good idea though I don't think we use either of those anywhere else, the standard seems be to be just use a combination of ^ and || which is good in that it's better at preventing unexpected behavior so I think we should just keep using
those

@GuySartorelli
Copy link
Member

I don't think we use either of those anywhere else

That's not a reason to not do it here, if it makes sense to do it here. I think it makes sense to do the forward-compatible thing here.

That said, it doesn't matter enough for me to push this back. Just adding a note here that when we encounter a problem caused by this come CMS 7 time, we should update to use forward-compatible constraint at that time so we don't have to touch this every time we do a major release.

@GuySartorelli GuySartorelli merged commit 80def07 into silverstripe:1.7 Feb 25, 2024
4 checks passed
@GuySartorelli GuySartorelli deleted the pulls/1.7/recipe-testing-4 branch February 25, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants