Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Resolve final callout block issues #285

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented Feb 1, 2024

This PR fixes two final callout block issues:

  1. A paragraph might not be the last item in the callout block - we should remove the bottom margin from the last element regardless of what that element is.
    E.g. see the list in a callout block in https://docs.silverstripe.org/en/5/developer_guides/templates/syntax/#variables
  2. Links in callout blocks weren't being parsed, and therefore weren't rendering correctly. E.g. see "Formatting, Modifying and Casting Variables" in https://docs.silverstripe.org/en/5/developer_guides/templates/syntax/

Issue

@GuySartorelli GuySartorelli changed the title FIX Remove unnecessary space at the end of callout blocks FIX Resolve final callout block issues Feb 1, 2024
@emteknetnz emteknetnz merged commit 8ce02bc into silverstripe:master Feb 2, 2024
8 checks passed
@emteknetnz emteknetnz deleted the pulls/master/fix-calloutblock-styling branch February 2, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants