DOC Deprecations for validators #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
emteknetnz
changed the title
emteknetnz
force-pushed
the
pulls/5/depr-valid
branch
2 times, most recently
from
f185fd5 to
4b3b88b
Compare
emteknetnz
force-pushed
the
pulls/5/depr-valid
branch
from
4b3b88b to
d84ca21
Compare
emteknetnz
force-pushed
the
pulls/5/depr-valid
branch
2 times, most recently
from
5d6636b to
6904fa6
Compare
GuySartorelli
requested changes
Dec 5, 2024
en/08_Changelogs/5.4.0.md
Outdated
| @@ -203,6 +203,12 @@ The `SilverStripe\CMS\Model\SiteTree.DESCRIPTION` localisation key (along with t | |||
| - [`RemoteFileModalExtension::getSchemaResponse()`](api:SilverStripe\AssetAdmin\Extensions\RemoteFileModalExtension::getSchemaResponse()) has been deprecated. It will be replaced with `RemoteFileModalExtension::getOwner()->getSchemaResponse()`. | |||
| - [`InternalLinkModalExtension`](api:SilverStripe\CMS\Forms\InternalLinkModalExtension) has been deprecated. It will be replaced with configuration on [`ModalController`](api:SilverStripe\Admin\ModalController). | |||
| - [`FormField::validate()`](api:SilverStripe\Forms\FormField::validate()) will take zero arguments and return a ValidationResult object instead of a boolean in CMS 6.0.0. | |||
| - [`FieldsValidator`](api:SilverStripe\Forms\FieldsValidator) has been deprecated. It will be replaced with functionality inside Silverstripe\Forms\Form::validate(). | |||
There was a problem hiding this comment.
Suggested change
| - [`FieldsValidator`](api:SilverStripe\Forms\FieldsValidator) has been deprecated. It will be replaced with functionality inside Silverstripe\Forms\Form::validate(). | |
| - [`FieldsValidator`](api:SilverStripe\Forms\FieldsValidator) has been deprecated. It will be replaced with functionality inside [`Form::validate()`](api:Silverstripe\Forms\Form::validate()). |
emteknetnz
force-pushed
the
pulls/5/depr-valid
branch
from
6904fa6 to
a6f4dd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#10908