MNT Move linting to a dedicated repository #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
GuySartorelli
commented
Apr 2, 2024
GuySartorelli
force-pushed
the
pulls/5.1/migrate-linting
branch
6 times, most recently
from
a6a2ec8 to
9987070
Compare
GuySartorelli
commented
Apr 3, 2024
GuySartorelli
force-pushed
the
pulls/5.1/migrate-linting
branch
from
9987070 to
d749273
Compare
emteknetnz
requested changes
Apr 4, 2024
.ss-docs-lint
Outdated
| @@ -0,0 +1 @@ | |||
| en/ | |||
.github/workflows/ci.yml
Outdated
| LINT_LANG=${{ matrix.lint_lang }} | ||
| FLAG="--with-${LINT_LANG#lint-}" | ||
| # Run the script | ||
| vendor/bin/ss-docs-lint $FLAG |
There was a problem hiding this comment.
Suggested change
| vendor/bin/ss-docs-lint $FLAG | |
| vendor/bin/doclint $FLAG |
GuySartorelli
force-pushed
the
pulls/5.1/migrate-linting
branch
from
d749273 to
69b215e
Compare
emteknetnz
approved these changes
Apr 4, 2024
|
Builds are red though expected to go green in the future once documentation-linting is in packagist |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs silverstripe/documentation-lint#1 to be merged and tagged for CI to go green
Issue