Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Run module-standardiser #453

Merged
merged 1 commit into from
Feb 2, 2024
Merged

MNT Run module-standardiser #453

merged 1 commit into from
Feb 2, 2024

Conversation

GuySartorelli
Copy link
Member

This pull-request was created automatically by module-standardiser

@GuySartorelli GuySartorelli mentioned this pull request Jan 31, 2024
Closed
4 tasks
@GuySartorelli GuySartorelli force-pushed the pulls/5/module-standardiser-1706667308 branch 2 times, most recently from 16e7426 to b6f6a99 Compare February 1, 2024 02:43
emteknetnz
emteknetnz requested changes Feb 2, 2024
View reviewed changes
Copy link
Member

@emteknetnz emteknetnz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you double check these two workflows are relevant for dev docs?

If not, please update module-standardiser so that these workflows aren't added in the future

@GuySartorelli GuySartorelli force-pushed the pulls/5/module-standardiser-1706667308 branch from b6f6a99 to 975f73b Compare February 2, 2024 01:27
GuySartorelli
GuySartorelli commented Feb 2, 2024
View reviewed changes
Copy link
Member Author

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense for update-js to be here (in case of vulnerabilities or bugs in the code used for linting) - but I've removed dispatch-ci.

@emteknetnz
Copy link
Member

Merging without CI run as changes are a cron based workflow

@emteknetnz emteknetnz merged commit 4a59b47 into silverstripe:5 Feb 2, 2024
3 checks passed
@emteknetnz emteknetnz deleted the pulls/5/module-standardiser-1706667308 branch February 2, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @emteknetnz